-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix eslint #49595
Merged
Merged
Fix eslint #49595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamich
added
release_note:skip
Skip the PR/issue when compiling release notes
review
Team:AppArch
v7.5.0
labels
Oct 29, 2019
Pinging @elastic/kibana-app-arch (Team:AppArch) |
lizozom
approved these changes
Oct 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when green
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
💔 Build Failed |
💚 Build Succeeded |
streamich
added a commit
that referenced
this pull request
Oct 30, 2019
* fix: 🐛 fix unused persistedLog object * chore: 🤖 ignore ESLint rule * fix: 🐛 correct dependencies in useUnmount() hook * fix: 🐛 fix ESLint errors * chore: 🤖 disable ESLint rule * fix: 🐛 add savedQueryService to dependency list * fix: 🐛 fix ESLint errors in data plugin * chore: 🤖 fix self-closing ESLint rule * test: 💍 update Jest snapshot * refactor: 💡 memoize persistedLog in more idiomatic way * chore: 🤖 remomve unused import * chore: 🤖 revert possible test breaker * fix: 🐛 fix query bar merge errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes App Architecture linter errors reported here.